safetensor vs checkpoint
Hi, sorry to bother you, and thank you for your great work. on your github implamentation, the readme says "Model weights are available on Google Drive and Hugging Face. We recommend using Google Drive. Please download it and put it inside ./checkpoints/"
is there a reason the model version on googledrive is a .ckpt insted of a safetensor (which is also kindly provided by you on huggingface), im guessing compatability or accidental version upload(googledrive)? thank you.
The reason is that the Transformers library uses the safetensors format by default. So if you call model.push_to_hub("your-hf-username/vfusion3d"), it will push safetensors by default.
It's a bit unclear why the authors recommend Google Drive above the hub, that's... unfortunate :( I assume weights are identical. Maybe @JunlinHan could clarify this
@nielsr
I feel this will be updated. I worked on the HF implementation (and converted the weights to safetensors) if you recall, and it was likely a timeline issue (VFusion wasn't on Hugging Face when the GitHub README was written).
Of course safetensors is better!
I can open a PR if
@JunlinHan
wants.
Thanks, that'd be great!
Yes, here is the PR for this issue on GitHub: https://github.com/facebookresearch/vfusion3d/pull/14
Waiting for Junlin's confirmation!
Hey guys, very sorry for my late response.
Many thanks nielsr for raising the issue and providing helpful suggestions!
And thank you Jade for making the PR.
PR accepted, thanks!