But immigration advocates argue that scrapping the concept of birthright citizenship would do away with a vital principle, and would be counterproductive to the stated goals of those who, like Mr. Trump, rail routinely against illegal immigration.